Skip to content

feat(mssql-driver): Return numeric result values as strings #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 22, 2025
Merged

feat(mssql-driver): Return numeric result values as strings #9485

merged 11 commits into from
Apr 22, 2025

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Apr 17, 2025 •
edited
Loading

This PR includes:

  • Switch driver codebase to typescript, filling types.
  • Update the underlying mssql package to the latest (v11).
  • Provide value handlers for numeric types - so now the result's numeric values are converted to strings. This helps avoid problems with big numbers and some other ambiguities and is more aligned with the Cube's results processing.

This fixes #9452

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.47%. Comparing base (2e8126d) to head (48c03f5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
packages/cubejs-base-driver/src/BaseDriver.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2e8126d) and HEAD (48c03f5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2e8126d) HEAD (48c03f5)
cubesql 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #9485       +/-   ##
===========================================
- Coverage   83.91%   58.47%   -25.44%     
===========================================
  Files         229      167       -62     
  Lines       83681    14928    -68753     
  Branches        0     2955     +2955     
===========================================
- Hits        70218     8729    -61489     
+ Misses      13463     5853     -7610     
- Partials        0      346      +346
Flag Coverage Δ
cube-backend 58.47% <0.00%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/number-conversion branch from 7cabe12 to b1d314d Compare April 18, 2025 08:28
@KSDaemon KSDaemon force-pushed the fix/number-conversion branch 3 times, most recently from 5eaf135 to 3a7842b Compare April 18, 2025 10:14
@KSDaemon KSDaemon force-pushed the fix/number-conversion branch 5 times, most recently from 870b9b7 to f1e8b9e Compare April 18, 2025 19:40
@KSDaemon KSDaemon marked this pull request as ready for review April 18, 2025 20:36
@KSDaemon KSDaemon requested review from a team as code owners April 18, 2025 20:36
@KSDaemon KSDaemon force-pushed the fix/number-conversion branch from f1e8b9e to 48c03f5 Compare April 18, 2025 20:37
@KSDaemon KSDaemon merged commit 52da601 into master Apr 22, 2025
55 checks passed
@KSDaemon KSDaemon deleted the fix/number-conversion branch April 22, 2025 08:13
marianore-muttdata pushed a commit to MuttData/cube that referenced this pull request Jun 17, 2025
@KSDaemon @marianore-muttdata
feat(mssql-driver): Return numeric result values as strings (cube-js#…
a67752f 
…9485)

* code hygiene

* upgrade mssql pkg

* Switch to ts

* workaround for mssql types missed types

* add value transformators

* update snapshots

* Some updates to health check

* sync lock

* upd package.json

* fix package.json

* fix lint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovr ovr ovr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

REST API returns integers as decimals

3 participants

@KSDaemon @ovr